Update PyTorch version matrix for Python 3.13 support #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1 on Python 3.13
LoserCheems
requested review from
Evanwu1125,
SNHuan,
Thanksyy,
Copilot,
ftgreat,
juliohsu,
wubingheng111 and
zacliu2023
and removed request for
Copilot
LoserCheems
assigned
LoserCheems,
Copilot,
Evanwu1125,
ftgreat,
juliohsu,
SNHuan,
Thanksyy,
wubingheng111 and
zacliu2023
Contributor
There was a problem hiding this comment.
Pull Request Overview
Update the PyTorch version matrix to improve Python 3.13 compatibility by removing PyTorch 2.4.0 (which lacks Python 3.13 support) and adding a specific exclusion for PyTorch 2.5.1 on ARM architecture with Python 3.13.
- Remove PyTorch 2.4.0 from the version matrix
- Add exclusion rule for PyTorch 2.5.1 + Python 3.13 + ARM architecture combination
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
61
to
62
| - torch-version: "2.4.0" | ||
| python-version: "3.13" |
There was a problem hiding this comment.
The exclusion for PyTorch 2.4.0 with Python 3.13 should be removed since PyTorch 2.4.0 is no longer in the version matrix. This exclusion rule is now redundant and creates maintenance overhead.
Suggested change
| - torch-version: "2.4.0" | |
| python-version: "3.13" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for PyTorch 2.4.0 and add support for PyTorch 2.5.1 on Python 3.13 in the version matrix.