Removes unused template parameter from DynamicMask #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the template signature by removing the kNThreads parameter that was not being used within the struct definition, reducing template complexity without affecting functionality.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the DynamicMask template by removing the unused kNThreads parameter, streamlining its signature without altering behavior.
- Removed
kNThreadstemplate parameter fromDynamicMask - Simplified template instantiation requirements
Comments suppressed due to low confidence (2)
csrc/src/mask.h:23
- Update any comments or documentation that reference the
kNThreadsparameter to reflect its removal from theDynamicMasktemplate signature.
template <bool Is_causal>
csrc/src/mask.h:23
- Ensure that all usages and specializations of
DynamicMaskelsewhere in the codebase have been updated to remove thekNThreadstemplate argument, otherwise builds will fail.
template <bool Is_causal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the template signature by removing the kNThreads parameter that was not being used within the struct definition, reducing template complexity without affecting functionality.