Skip to content

Conversation

@LoserCheems
Copy link
Collaborator

Reorganizes the order of stride parameter assignments to group related parameters together for better code readability and maintainability.

Adds missing column stride assignments for zoh and active_mask tensors.

Reorganizes the order of stride parameter assignments to group related parameters together for better code readability and maintainability.

Adds missing column stride assignments for zoh and active_mask tensors.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reorganizes the assignment order of output strides and introduces missing column-stride parameters for zoh and active_mask tensors to improve readability and ensure all tensor strides are captured.

  • Reordered o_row_stride next to other row-stride assignments.
  • Added zoh_col_stride and active_mask_col_stride assignments.
  • Grouped related stride assignments by “row”, “head”, and now “col”.
Comments suppressed due to low confidence (2)

csrc/flash_api.cpp:85

  • New column-stride assignments for zoh and active_mask have been added but aren’t covered by existing tests. Please add unit tests to verify these stride values.
    params.zoh_col_stride = zoh.stride(-1);

csrc/flash_api.cpp:85

  • Update the set_params_fprop function header or the params struct documentation to include descriptions of the new zoh_col_stride and active_mask_col_stride fields.
    params.zoh_col_stride = zoh.stride(-1);

@LoserCheems LoserCheems merged commit e577178 into main Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants