Skip to content

Improves code clarity and test coverage #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Improves code clarity and test coverage #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37171b5
Improves code clarity and test coverage
LoserCheems Jun 30, 2025
33c67a5
Update benchmarks/benchmark_forward_equivalence.py
LoserCheems Jun 30, 2025
8d8a7fe
Adds type ignore comment for CUDA import
LoserCheems Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions benchmarks/benchmark_forward_equivalence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

# Import the compiled CUDA extension
try:
import flash_dma_cuda
import flash_dma_cuda # type: ignore[import]
print("✅ Successfully imported flash_dma_cuda")
except ImportError as e:
print(f"❌ Failed to import flash_dma_cuda: {e}")
Expand Down Expand Up @@ -236,7 +236,7 @@ def dynamic_mask_attention_cuda(
query_states, # q: [batch, seqlen_q, num_heads, head_dim]
key_states, # k: [batch, seqlen_k, num_kv_heads, head_dim]
value_states, # v: [batch, seqlen_k, num_kv_heads, head_dim]
attn_mask, # zoh: [batch, num_kv_heads, seqlen_q, seqlen_k] - processed attention mask
zero_hold_states, # zoh: [batch, num_kv_heads, seqlen_q, seqlen_k] - processed attention mask
active_mask, # active_mask: [batch, num_kv_heads, seqlen_q, seqlen_k]
out_tensor, # out: None to auto-allocate
0.0, # p_dropout
Expand Down Expand Up @@ -377,7 +377,7 @@ def test_forward_equivalence(accuracy_threshold=0.95):
(1, 2, 1, 64, 64, 128, True),
(1, 2, 1, 128, 128, 128, True),
(1, 2, 1, 256, 256, 128, True),
(1, 2, 1, 2, 256, 128, True),
(1, 2, 1, 511, 512, 128, True),
]

device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/benchmark_forward_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

# Import the compiled CUDA extension
try:
import flash_dma_cuda
import flash_dma_cuda # type: ignore[import]
print("✅ Successfully imported flash_dma_cuda")
except ImportError as e:
print(f"❌ Failed to import flash_dma_cuda: {e}")
Expand Down