Updates copy function defaults and clarifies comments #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes default Clear_OOB_MN parameter to true for safer out-of-bounds handling. Updates tensor dimension comments to use more descriptive MMA_M and MMA_N naming convention for better code clarity.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the out-of-bounds clearing behavior safer by enabling it by default and improves the clarity of tensor-dimension comments.
- Change default Clear_OOB_MN parameter from
falsetotruefor safer out-of-bounds handling - Update comments to use descriptive
MMA_MandMMA_Nnaming for tensor dimensions
Comments suppressed due to low confidence (3)
csrc/src/utils.h:500
- Update the function's documentation/comments to mention that
Clear_OOB_MNnow defaults totrue, ensuring that code comments stay in sync with the new behavior.
template <bool Is_even_MN=true, bool Clear_OOB_MN=true,
csrc/src/utils.h:500
- Add or update unit tests to cover the new out-of-bounds clearing behavior, verifying that elements outside valid ranges are correctly zeroed when
Clear_OOB_MN=true.
template <bool Is_even_MN=true, bool Clear_OOB_MN=true,
csrc/src/utils.h:500
- Changing
Clear_OOB_MNdefault to true may introduce additional clearing overhead; consider benchmarking the performance impact or making this behavior explicit in performance-critical contexts.
template <bool Is_even_MN=true, bool Clear_OOB_MN=true,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes default Clear_OOB_MN parameter to true for safer out-of-bounds handling.
Updates tensor dimension comments to use more descriptive MMA_M and MMA_N naming convention for better code clarity.