Fixes mask validation in forward kernel #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces hardcoded True value with proper mask evaluation logic to correctly determine if any elements in the mask are active, ensuring accurate conditional processing in the attention mechanism.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the mask validation in the forward triton kernel by replacing a hardcoded True with a proper check that determines if any mask elements are active.
- Restores the original
tl.sum(mask > 0) > 0logic forany_active. - Removes the hardcoded
Trueassignment. - Ensures conditional processing in the attention mechanism is accurate.
Comments suppressed due to low confidence (1)
flash_dmattn/flash_dmattn_triton.py:135
- Add a unit test for the scenario where the mask has no active elements to verify that
any_activecorrectly evaluates toFalseand that the attention mechanism handles this case as expected.
any_active = tl.sum(mask > 0) > 0
| # Check if any element in mask is non-zero | ||
| # any_active = tl.sum(mask > 0) > 0 | ||
| any_active = True | ||
| any_active = tl.sum(mask > 0) > 0 |
There was a problem hiding this comment.
[nitpick] Remove the commented-out legacy code now that the proper mask check is active to reduce clutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded True value with proper mask evaluation logic to correctly determine if any elements in the mask are active, ensuring accurate conditional processing in the attention mechanism.