Improves version comparison using packaging library #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces string-based version comparison with proper semantic version parsing to ensure accurate comparison of PyTorch versions. Uses packaging.version.parse() instead of direct string comparison to handle edge cases and version formats correctly.
LoserCheems
requested review from
Evanwu1125,
SNHuan,
Copilot and
wubingheng111
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves version comparison by replacing string-based PyTorch version comparison with proper semantic version parsing using the packaging library. This ensures more reliable version comparisons that handle edge cases and different version formats correctly.
- Replaces direct string comparison of PyTorch versions with
packaging.version.parse() - Adds import for the
packaging.versionmodule
Comments suppressed due to low confidence (1)
flash_dmattn/flash_dmattn_interface.py:4
- The packaging library may not be available in all environments. Consider adding error handling or ensure packaging is included in the project's dependencies.
from packaging import version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces string-based version comparison with proper semantic version parsing to ensure accurate comparison of PyTorch versions.
Uses packaging.version.parse() instead of direct string comparison to handle edge cases and version formats correctly.