Streamlines benchmark suite structure and test scope #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes obsolete MQAR benchmark configuration and reorganizes benchmark files with cleaner naming convention. Comments out extensive test configurations to focus on essential test cases, reducing test execution time while maintaining core functionality validation. Simplifies the benchmark suite to improve maintainability and development workflow efficiency.
…h-dmattn into Support-backward
LoserCheems
requested review from
Evanwu1125,
SNHuan,
Copilot and
wubingheng111
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
Streamlines the benchmark suite by removing obsolete MQAR benchmark configuration and commenting out extensive test configurations to focus on essential test cases, reducing execution time while maintaining core functionality validation.
- Removes entire MQAR benchmark configuration file
- Comments out majority of test configurations in performance and equivalence benchmarks
- Disables triton and flex attention test modes in equivalence testing
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| benchmarks/benchmark_mqar.py | Complete removal of MQAR benchmark configuration |
| benchmarks/forward_performance.py | Comments out extensive performance test configurations, keeping only essential cases |
| benchmarks/forward_equivalence.py | Comments out most equivalence test configurations and disables triton/flex test modes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#98
Removes obsolete MQAR benchmark configuration and reorganizes benchmark files with cleaner naming convention.
Comments out extensive test configurations to focus on essential test cases, reducing test execution time while maintaining core functionality validation.
Simplifies the benchmark suite to improve maintainability and development workflow efficiency.