Account for DA and gas limit in flashblocks #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
reviewed
Jun 3, 2025
| let da_per_batch = ctx | ||
| .da_config | ||
| .max_da_block_size() | ||
| let da_per_batch = adjusted_max_da_block_limit |
There was a problem hiding this comment.
You are adjusting every flashblock for a builder txn, but only the last one has a builder txn
There was a problem hiding this comment.
Yes, i wrote TODO for this
but could implement it straight away
There was a problem hiding this comment.
It would be great in the scope of this PR.
SozinM
force-pushed
the
msozin/fix-da-flashblocks-builder-tx
branch
from
f800970 to
fc9a175
Compare
karim-agha
reviewed
Jun 3, 2025
| } | ||
| let mut total_da_per_batch = da_per_batch; | ||
|
|
||
| let last_flashblock = self.config.flashblocks_per_block() - 1; |
added 2 commits
June 3, 2025 19:33
SozinM
force-pushed
the
msozin/fix-da-flashblocks-builder-tx
branch
from
0d23f66 to
07b9c34
Compare
ferranbt
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #90
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test