Add block number and DA used to logging #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cody-wang-cb
requested review from
SozinM,
avalonche,
ferranbt and
karim-agha
as code owners
SozinM
approved these changes
Jun 3, 2025
avalonche
reviewed
Jun 3, 2025
avalonche
reviewed
Jun 3, 2025
avalonche
reviewed
Jun 3, 2025
There was a problem hiding this comment.
instead of string format, we can use structured logging as in https://github.com/flashbots/op-rbuilder/blob/tx-debug/crates/op-rbuilder/src/builders/context.rs#L286
|
@avalonche good point! just updated to use structured logs |
ferranbt
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adding block number to building logs allows to debug things more easily, also adding da used.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test