Custom engine api plain #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
force-pushed
the
msozin/custom-engine-api-basic
branch
3 times, most recently
from
036b24b to
d9bee29
Compare
Rebase Remove custom logic Custom Engine API support + engine call propagation
SozinM
force-pushed
the
msozin/custom-engine-api-basic
branch
from
85336d7 to
7b56620
Compare
ferranbt
reviewed
Jun 6, 2025
| .wrapping_div(1_000_000), | ||
| ) | ||
| Ok(op_alloy_flz::tx_estimated_size_fjord_bytes( | ||
| builder_tx.encoded_2718().as_slice(), |
There was a problem hiding this comment.
I am confused now, we are not dividing anymore?
There was a problem hiding this comment.
Yes, i used the fixed version of the call (from fix i made for reth)
ferranbt
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR create plugin-in replacement for basic engine API
It doesn't have any extra logic
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test