Account for flashblocks time drift #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
force-pushed
the
msozin/flashblock-time-drift-account
branch
from
9b5a4b6 to
80d0eaf
Compare
|
@danyalprout this is my take on the FB timing issue |
SozinM
commented
Jun 5, 2025
SozinM
force-pushed
the
msozin/flashblock-time-drift-account
branch
3 times, most recently
from
57428b1 to
e161d65
Compare
added 5 commits
June 17, 2025 17:43
Account for dynamic lag in the beginning of building process
SozinM
force-pushed
the
msozin/flashblock-time-drift-account
branch
from
e161d65 to
ee3ae84
Compare
SozinM
force-pushed
the
msozin/flashblock-time-drift-account
branch
from
d2ebe5b to
896046f
Compare
ferranbt
approved these changes
Jun 17, 2025
krl
approved these changes
Jun 17, 2025
| // FCU(a) could arrive with `fb_time < delay < block_time - fb_time` - in this case we will issue less flashblocks | ||
| let time = std::time::SystemTime::UNIX_EPOCH + Duration::from_secs(timestamp) | ||
| - self.config.specific.leeway_time; | ||
| let time_drift = time.duration_since(std::time::SystemTime::now()).ok(); |
There was a problem hiding this comment.
Would it not be more clear to match on the error directly, instead of assigning and unpacking with .ok()?
something like
match time.duration_since(std::time::SystemTime::now()) { Ok(drift) , Err(SystemTimeError(amount) }There was a problem hiding this comment.
i'm using it later and it makes more sense for it to being the option imo
added 2 commits
June 17, 2025 18:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test