Split op-rbuilder in lib and main #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
reviewed
Jun 9, 2025
crates/op-rbuilder/src/launcher.rs
Outdated
| // Prefer jemalloc for performance reasons. | ||
| #[cfg(all(feature = "jemalloc", unix))] | ||
| #[global_allocator] | ||
| static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc; |
There was a problem hiding this comment.
We should move this to main, because lib shouldn't set global allocator
Closed
SozinM
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Before, in the src folder we had both a
main.rsfunction and an importlib.rsone. This setup created problems because methods exported in lib were not available for main since I believe the execution contexts were different.This PR changes that and splits the op-rbuilder in two components, a library (under
src) and the op-rbuilder main binary (underbin) which consumes the library. Other than the main split in functionality this PR does not introduce any other ergonomics about how to structure better the library to be consumed by the main binary. I will leave that to followup PRs that consume this functionality.