Add metric to count reverted bundles #151
Conversation
akundaz
requested review from
SozinM,
avalonche,
ferranbt and
karim-agha
as code owners
|
I wasn't sure if any instance in which |
| self.send_bundle_inner(bundle) | ||
| .await | ||
| .inspect(|_| self.metrics.bundles_received.increment(1)) | ||
| .inspect_err(|_| self.metrics.bundles_reverted.increment(1)) |
There was a problem hiding this comment.
We should do this in execute_best_transactions
There was a problem hiding this comment.
But that function is executing transactions, not bundles. Where do we try to execute a bundle?
There was a problem hiding this comment.
I think bundle execution happens somewhere there too
There was a problem hiding this comment.
You could also check build_payload, I saw something related to bundles there
There was a problem hiding this comment.
I think I found the indicator -- there's a comment that if reverted_hashes.is_some() then the transaction comes from a bundle.
akundaz
force-pushed
the
ash-qqsnzlokowny
branch
from
97f2678 to
7f041a6
Compare
3 participants
📝 Summary
Count the number of reverted bundles
💡 Motivation and Context
We can get spammed by bad bundles so we should track this
Resolves #150
✅ I have completed the following steps:
make lintmake test