Implement correct flashblocks time cutoff #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Now control loop is issuing flashblock level cancel tokens that we use to cancel execute_best_transaction when it's time to create new flashblock
This is critical fix
It fixes the bug with first flashblocks sending timing (if there no txs in the network it would be fired almost immediately)
Because we fixed bug with first flashblock time flow in generally became a little bit more brittle (because previously we were running equivalent to fixed mode with 200ms leeway-time )
💡 Motivation and Context
✅ I have completed the following steps:
make lint
make test