Skip to content

Improve metrics so we could better plot them #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Improve metrics so we could better plot them #193

merged 1 commit into from
Jul 9, 2025

Conversation

SozinM
Copy link
Collaborator

@SozinM SozinM commented Jul 9, 2025 •
edited
Loading

📝 Summary

Initial metrics were reversed (when lower values - worse) and it wasn't nice for histogram

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@SozinM SozinM requested a review from akundaz July 9, 2025 12:47
@SozinM SozinM merged commit dc1b00c into main Jul 9, 2025
2 checks passed
@SozinM SozinM deleted the msozin/fix-flashblocks-metrics branch July 9, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avalonche avalonche Awaiting requested review from avalonche avalonche is a code owner

@karim-agha karim-agha Awaiting requested review from karim-agha karim-agha is a code owner

@akundaz akundaz Awaiting requested review from akundaz

1 more reviewer

@ferranbt ferranbt ferranbt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SozinM @ferranbt