Skip to content

Add a test to validate that no-tx-pool works #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Add a test to validate that no-tx-pool works #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d51608
Add a test to validate that no-tx-pool works
ferranbt Jul 11, 2025
dc17ea7
Fix lint
ferranbt Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/op-rbuilder/src/tests/framework/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ impl<RpcProtocol: Protocol> ChainDriver<RpcProtocol> {

// public test api
impl<RpcProtocol: Protocol> ChainDriver<RpcProtocol> {
pub async fn build_new_block_with_no_tx_pool(&self) -> eyre::Result<Block<Transaction>> {
self.build_new_block_with_txs_timestamp(vec![], Some(true), None, None)
.await
}

/// Builds a new block using the current state of the chain and the transactions in the pool.
pub async fn build_new_block(&self) -> eyre::Result<Block<Transaction>> {
self.build_new_block_with_txs(vec![]).await
Expand All @@ -104,14 +109,15 @@ impl<RpcProtocol: Protocol> ChainDriver<RpcProtocol> {
&self,
timestamp_jitter: Option<Duration>,
) -> eyre::Result<Block<Transaction>> {
self.build_new_block_with_txs_timestamp(vec![], None, timestamp_jitter)
self.build_new_block_with_txs_timestamp(vec![], None, None, timestamp_jitter)
.await
}

/// Builds a new block with provided txs and timestamp
pub async fn build_new_block_with_txs_timestamp(
&self,
txs: Vec<Bytes>,
no_tx_pool: Option<bool>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why an option? can just set true for build_new_block_with_no_tx_pool and false everywhere else

block_timestamp: Option<Duration>,
// Amount of time to lag before sending FCU. This tests late FCU scenarios
timestamp_jitter: Option<Duration>,
Expand Down Expand Up @@ -178,6 +184,7 @@ impl<RpcProtocol: Protocol> ChainDriver<RpcProtocol> {
},
transactions: Some(vec![block_info_tx].into_iter().chain(txs).collect()),
gas_limit: Some(self.gas_limit.unwrap_or(DEFAULT_GAS_LIMIT)),
no_tx_pool,
..Default::default()
})
.await?;
Expand Down Expand Up @@ -259,7 +266,7 @@ impl<RpcProtocol: Protocol> ChainDriver<RpcProtocol> {
let latest_timestamp = Duration::from_secs(latest.header.timestamp);
let block_timestamp = latest_timestamp + Self::MIN_BLOCK_TIME;

self.build_new_block_with_txs_timestamp(txs, Some(block_timestamp), None)
self.build_new_block_with_txs_timestamp(txs, None, Some(block_timestamp), None)
.await
}

Expand Down
13 changes: 13 additions & 0 deletions crates/op-rbuilder/src/tests/smoke.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,16 @@ async fn produces_blocks_under_load_within_deadline(rbuilder: LocalInstance) ->

Ok(())
}

#[rb_test]
async fn test_no_tx_pool(rbuilder: LocalInstance) -> eyre::Result<()> {
let driver = rbuilder.driver().await?;

// make sure we can build a couple of blocks first
let _ = driver.build_new_block().await?;

// now lets try to build a block with no transactions
let _ = driver.build_new_block_with_no_tx_pool().await?;

Ok(())
}
Loading