Skip to content

Conversation

akundaz
Copy link
Contributor

@akundaz akundaz commented Jul 16, 2025

📝 Summary

Add gauge metrics for many metrics that happen once during block building. Also fix a few of the flashblocks metrics that were using the same payload metrics that normal block building used.

💡 Motivation and Context

Many of the current metrics that are recorded once per block are tracked with histograms, but it would be more useful to use gauges for them to get more accurate metrics for them. This is a somewhat common pattern, to use both a histogram and a gauge to track something, as seen in paradigmxyz/reth#10728.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@akundaz akundaz self-assigned this Jul 16, 2025
Copy link
Collaborator

@avalonche avalonche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great if there was a metrics test

@akundaz akundaz force-pushed the ash-yqlpsylmpozl branch from 144f02e to 18694f1 Compare July 17, 2025 13:24
@akundaz
Copy link
Contributor Author

akundaz commented Jul 17, 2025

would be great if there was a metrics test

Yeah, I'll look into this and try it out in a separate PR

@akundaz akundaz merged commit d987794 into main Jul 17, 2025
4 checks passed
@akundaz akundaz deleted the ash-yqlpsylmpozl branch July 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants