feat: overwrite reth default cache directory #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Close #232
Overwrite current
<CACHE_DIR>/reth/logs
directory for log files to<CACHE_DIR>/op-rbuilder/logs
directory.Still configurable with
--log.file.directory
arg.💡 Motivation and Context
Using reth's
Cli
, we already inherit different tracing layers for logging.The default value for the file logger point to
<CACHE_DIR>/reth/logs
.If running op-rbuilder with reth, this can mix cache files.
This PR correctly set the file log output. You can access by default debug level trace and access log at:
~/.cache/op-rbuilder/logs
on Linux~/Library/Caches/op-rbuilder/logs
on macOS%localAppData%/op-rbuilder/logs
on WindowsAdditional file logging configuration (accessible with
--help
):The log file is still named
reth.log
, this open PR should make it configurable paradigmxyz/reth#17883✅ I have completed the following steps:
make lint
make test