fix: flashblock contraints in bundle api #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akundaz
requested review from
SozinM,
avalonche and
karim-agha
as code owners
akundaz
commented
Sep 11, 2025
| FBPooledTransaction { | ||
| inner: self.inner.with_conditional(conditional), | ||
| reverted_hashes: self.reverted_hashes, | ||
| flashblock_number_min: None, |
There was a problem hiding this comment.
this was overriding the param and making it None, this keeps the param that's already set
SozinM
reviewed
Sep 11, 2025
SozinM
reviewed
Sep 11, 2025
SozinM
approved these changes
Sep 11, 2025
akundaz
force-pushed
the
ak-fix-bundle-flashblock
branch
from
1bf60e6 to
7097e1c
Compare
akundaz
force-pushed
the
ak-fix-bundle-flashblock
branch
from
7097e1c to
552cb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Transactions would appear in the wrong flashblock when
flashblock_number_min/flashblock_number_maxwere set. This was because the params were not being propagated correctly and is fixed with this PR.Additional changes:
BundleOptstypeFlashblocksListenerto read from the ws ergonomically💡 Motivation and Context
The flashblock min and max bundle params were not being respected
✅ I have completed the following steps:
make lintmake test