Skip to content

Conversation

@avalonche
Copy link
Collaborator

πŸ“ Summary

Remove non permit calls and mark to be deprecated

πŸ’‘ Motivation and Context


βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

Copilot AI review requested due to automatic review settings October 22, 2025 20:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated non-permit flashtestation calls and marks the old funding-based approach for deprecation. The changes streamline the flashtestation system to use only permit-based signatures for TEE service registration and block proofs.

Key changes:

  • Removed funding-based TEE registration flow in favor of permit-only approach
  • Eliminated funding key parameter and related funding transactions
  • Removed cleanup tasks for returning funds from TEE-generated keys

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/op-rbuilder/src/tests/flashtestations.rs Removed test attributes for deprecated non-permit tests; added flashtestations_use_permit: true to remaining tests; removed funding_key parameter from test configurations
crates/op-rbuilder/src/flashtestations/tx_manager.rs Replaced funding-based registration with permit-based registration; removed fund_address and clean_up methods; renamed funding_signer to builder_signer; added EIP-2612 permit signature generation
crates/op-rbuilder/src/flashtestations/service.rs Removed funding_key parameter and cleanup task; simplified bootstrap to only handle permit-based registration; removed BuilderContext parameter
crates/op-rbuilder/src/flashtestations/builder_tx.rs Removed deprecated funding and non-permit registration methods; simplified transaction generation to only use permit-based approach; removed funding_key, funding_amount, and use_permit fields
crates/op-rbuilder/src/flashtestations/args.rs Removed funding_key and funding_amount CLI arguments; marked flashtestations_use_permit as deprecated with default changed to true
crates/op-rbuilder/src/builders/standard/service.rs Removed ctx parameter from bootstrap_flashtestations call
crates/op-rbuilder/src/builders/flashblocks/service.rs Removed ctx parameter from bootstrap_flashtestations call

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@avalonche avalonche force-pushed the remove-flashtestation-non-permit branch from 3a260c8 to 4f0411e Compare October 22, 2025 20:07
Copilot AI review requested due to automatic review settings October 22, 2025 22:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

let quote_bytes = Bytes::from(attestation);
let wallet =
PrivateKeySigner::from_bytes(&self.tee_service_signer.secret.secret_bytes().into())
PrivateKeySigner::from_bytes(&self.builder_signer.secret.secret_bytes().into())
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wallet is created from builder_signer but should be created from tee_service_signer to sign the permit registration transaction. The TEE service signer is the one that needs to authorize the registration via permit, not the builder signer.

Suggested change
PrivateKeySigner::from_bytes(&self.builder_signer.secret.secret_bytes().into())
PrivateKeySigner::from_bytes(&self.tee_service_signer.secret.secret_bytes().into())

Copilot uses AI. Check for mistakes.
Comment on lines 88 to 90
/// DEPRECATED FLAG: Permit-based signatures are now the default and only supported method.
/// This flag is no longer necessary and will be removed in future versions.
/// Users should rely on the default permit-based signature workflow.
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states this flag is deprecated, but it's still functional and being used. If the flag truly has no effect (since permit is now always used), consider removing it entirely or adding a runtime warning when it's set to false to inform users of the deprecation.

Copilot uses AI. Check for mistakes.
@avalonche avalonche force-pushed the remove-flashtestation-non-permit branch from aed9dd4 to 0de3c2d Compare October 22, 2025 22:33
Copy link
Contributor

@akundaz akundaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just check the copilot comment on changing tee_service_signer to builder_signer

@avalonche
Copy link
Collaborator Author

that's the intended wallet for signing the transaction, tee signer signs the message

@avalonche avalonche merged commit b601bcd into main Oct 23, 2025
10 checks passed
@avalonche avalonche deleted the remove-flashtestation-non-permit branch October 23, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants