Feat/revert protection status endpoint #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
May 28, 2025
crates/op-rbuilder/src/main.rs
Outdated
| let da_config = builder_config.da_config.clone(); | ||
| let rollup_args = builder_args.rollup_args; | ||
| let op_node = OpNode::new(rollup_args.clone()); | ||
| let reverted_cache = create_shared_cache(100); |
There was a problem hiding this comment.
I am open minded to do this in a different way. I have another PR to modify the transaction pool monitor so I think this could get cleaner once that lands and there is a concrete TxPoolMonitor structure.
karim-agha
approved these changes
May 28, 2025
Comment on lines
72
to
80
| pub type SharedLruCache<K, V> = Arc<Mutex<LruCache<K, V>>>; | ||
|
|
||
| pub fn create_shared_cache<K, V>(capacity: usize) -> SharedLruCache<K, V> | ||
| where | ||
| K: std::hash::Hash + Eq, | ||
| { | ||
| let cache = LruCache::new(NonZeroUsize::new(capacity).unwrap()); | ||
| Arc::new(Mutex::new(cache)) | ||
| } |
There was a problem hiding this comment.
I'd suggest using Moka instead of this because if we use Arc-Mutex we will be only serving one RPC call at a time and won't have scalable/concurrent RPC API.
SozinM
reviewed
May 28, 2025
| Some(receipt) => Ok(Some(receipt)), | ||
| None => { | ||
| // Try to find the transaction in the reverted cache | ||
| let reverted_cache = self.reverted_cache.lock().unwrap(); |
There was a problem hiding this comment.
I think ideally we want to use some kind of lock that would prioritize writers
also with sync mutex you could rect the runtime
There was a problem hiding this comment.
DashSet is also a descent option.
SozinM
reviewed
May 28, 2025
|
|
||
| if let Some(revert_protection) = self.with_revert_protection { | ||
| if revert_protection { | ||
| println!("revert_protection is enabled"); |
SozinM
reviewed
May 28, 2025
SozinM
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #46
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test