Add builder txn to Flashblocks #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
commented
May 30, 2025
| /// flashblock block time in milliseconds | ||
| #[arg( | ||
| long = "flashblock.block-time", | ||
| long = "flashblocks.block-time", |
There was a problem hiding this comment.
I am changing this flag too so that all of them have the same prefix
ferranbt
commented
May 30, 2025
|
|
||
| // If it is the last flashblocks, add the builder txn to the block if enabled | ||
| if flashblock_count == self.config.flashblocks_per_block() - 1 { | ||
| // TODO: Account for DA size limits |
There was a problem hiding this comment.
Important note. It does not account neither yet for DA limits nor for gas limits. It is still a bit of an heuristic we have to figure out how to split gas limit and DA limit in flashblocks.
There was a problem hiding this comment.
I thought we want a builder tx for every flashblock?
ferranbt
commented
May 30, 2025
| revert_protection: args.enable_revert_protection, | ||
| block_time: Duration::from_millis(args.chain_block_time), | ||
| block_time_leeway: Duration::from_millis(500), | ||
| block_time_leeway: Duration::from_secs(args.extra_block_deadline_secs), |
There was a problem hiding this comment.
This was missing, the flag extra-block-deadline-secs was not being used
karim-agha
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #80