Feat: CheckpointExt, SpanExt, Span doc + missing helpers #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
reviewed
Oct 9, 2025
|
|
||
| impl<P: Platform> SpanExt<P> for Span<P> { | ||
| /// Returns the total gas used by all checkpoints in the span. | ||
| fn gas_used(&self) -> u64 { |
There was a problem hiding this comment.
Could we have branching of checkpoint inside the span?
There was a problem hiding this comment.
No, spans represent continuous linear history of checkpoints.
SozinM
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented missing methods from SpanExt in CheckpointExt, such as
containsandblobs.Then SpanExt methods can just use CheckpointExt to not have to know too much about Checkpoint impls.
And rest is some improvements in doc and readability.