Skip to content

Conversation

noot
Copy link
Collaborator

@noot noot commented Sep 22, 2025

as title says, added the unreachable_pub lint and autofixed issues.

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 19:48
@noot noot requested a review from karim-agha as a code owner September 22, 2025 19:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the unreachable_pub lint to enforce better visibility control and systematically fixes all identified unreachable public items by changing them to appropriate restricted visibility (pub(crate), pub(super), or private).

  • Added unreachable_pub = "warn" lint to the workspace Cargo.toml
  • Reduced visibility of numerous public items that are not accessed outside their defining modules
  • Changed public struct definitions, impl methods, and re-exports to use more restrictive visibility

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Added unreachable_pub lint configuration
src/test_utils/step.rs Changed fake_step macro struct visibility to pub(super) and test utility methods to pub(crate)
src/test_utils/node.rs Changed pool method visibility to pub(crate)
src/steps/revert.rs Changed PerJobCounters methods from pub to pub(crate)
src/steps/ordering/mod.rs Changed SortedOrders::pop_best method to pub(crate)
src/pool/step.rs Changed Run methods and metrics structs to pub(crate)
src/pool/setup.rs Changed SystemPoolWrapper::new to pub(crate)
src/pool/select.rs Changed PoolsDemux::new to pub(crate)
src/pool/rpc.rs Changed BundleRpcApi::new to pub(super)
src/pool/native.rs Changed NativeTransactionPool struct and methods to pub(crate)
src/pool/mod.rs Changed OrderPoolInner::outer method and NativeTransactionPool re-export to pub(crate)
src/pool/host.rs Changed HostNode struct and methods to pub(super) or pub(crate)
src/platform/ethereum/pool.rs Changed FixedTransactions struct and methods to pub(super)
src/pipelines/step/name.rs Changed Name struct and methods to pub(super)
src/pipelines/step/metrics.rs Changed Metrics and PerJobCounters structs/methods to pub(super)
src/pipelines/step/instance.rs Changed StepInstance methods to pub(crate)
src/pipelines/service.rs Changed service-related structs and methods to pub(super)
src/pipelines/metrics.rs Changed Payload struct and methods to pub(super)
src/pipelines/macros/src/variants.rs Changed impl_into_pipeline_steps to pub(crate)
src/pipelines/macros/src/metrics/set.rs Changed metrics_set_derive to pub(crate)
src/pipelines/macros/src/metrics/mod.rs Changed metrics_set_derive re-export to pub(crate)
src/pipelines/limits.rs Changed test helper methods from pub to private
src/pipelines/job.rs Changed PayloadJob and ExecutorFuture structs/methods to pub(super)
src/pipelines/iter.rs Changed StepPathIter::new to pub(crate)
src/pipelines/exec/scope.rs Changed scope-related structs and methods to pub(crate)
src/pipelines/exec/navi.rs Changed StepPath and StepNavigator methods to pub(crate)
src/pipelines/exec/mod.rs Changed PipelineExecutor methods to pub(super)
src/pipelines/events.rs Changed EventsBus and system_events to pub(super)
examples/custom-bundle-type.rs Changed CustomBundleType::with_min_profit to private

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@noot noot merged commit fc9a707 into main Sep 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants