Skip to content

Conversation

julio4
Copy link
Collaborator

@julio4 julio4 commented Sep 24, 2025

Within is_eligible method of FlashbotsBundle:

  • self.block_number is checked against parent block number. I believe checking against the current payload's number is better?
  • Might be better to check PermanentlyIneligible first to prevent early returns of potential TemporarilyIneligible when the bundle should be considered as PermanentlyIneligible
  • if max_timestamp > block_timestamp then PermanentlyIneligible is incorrectly returned. It should be when max_timestamp < block_timestamp
  • Similarly, if min_timestamp < block_timestamp then TemporarilyIneligible is incorrectly returned. It should be when min_timestamp > block_timestamp

If this is correct, then the eligibility logic can be refactored in a eligibility_at(timestamp: u64, number: u64) and used in both is_eligible and is_permanently_ineligible methods.

@julio4 julio4 requested a review from karim-agha as a code owner September 24, 2025 05:47
@julio4 julio4 force-pushed the fix/flashbots-bundle-eligibility branch from 9892668 to f5fb38e Compare September 24, 2025 05:50
@julio4 julio4 force-pushed the fix/flashbots-bundle-eligibility branch from f5fb38e to 4d7919b Compare September 24, 2025 05:54
@dmarzzz dmarzzz merged commit d92b4f1 into flashbots:main Oct 6, 2025
3 checks passed
@julio4 julio4 deleted the fix/flashbots-bundle-eligibility branch October 6, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants