Fast relay concept is split between fast and independent #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
requested changes
May 1, 2025
| !has_replacement_uuid && !is_expensive_block | ||
| inc_initiated_submissions(optimistic, !only_fast, !only_independent); | ||
| move |relay: &MevBoostRelayBidSubmitter| { | ||
| if only_independent && !relay.is_independent() { |
Contributor
There was a problem hiding this comment.
I don't fully understand the logic from the description and the docs and this code. This means the description can be improved.
Relays can be independent and fast at the same time?
- only_fast bool is practically going to be true for every block
- only_independent will be true for big blocks
So what will happen for big blocks with replacements?
They will be sent only to fast AND independent relays. Is this intended behavior?
Collaborator
Author
There was a problem hiding this comment.
Updated the comments.
dvush
reviewed
May 1, 2025
| .any(|o| match o { | ||
| Order::Bundle(bundle) => bundle.replacement_data.is_some(), | ||
| Order::Tx(_) => false, | ||
| Order::ShareBundle(_) => false, |
Contributor
There was a problem hiding this comment.
share bundles can have replacements too
Contributor
|
here is a thread with explanations https://collective.flashbots.net/t/updated-mev-boost-relay-settings/4881 |
dvush
approved these changes
May 1, 2025
Contributor
dvush
left a comment
dvush
left a comment
There was a problem hiding this comment.
I don't have issues with implementation, only the docs, so I'll approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
✅ I have completed the following steps:
make lintmake test