Added cfg time_to_keep_mempool_txs_secs + metrics #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metric docs
dvush
reviewed
Aug 21, 2025
| /// This will update every 2.4 hours, super reasonable. | ||
| pub const DEFAULT_BLOCKLIST_URL_MAX_AGE_HOURS: u64 = 24; | ||
| pub const DEFAULT_REQUIRE_NON_EMPTY_BLOCKLIST: bool = false; | ||
| pub const DEFAULT_TIME_TO_KEEP_MEMPOOL_TXS_SECS: u64 = 1; |
Contributor
There was a problem hiding this comment.
Why default is 1 sec? We kept mempool txs for couple of blocks before
Collaborator
Author
There was a problem hiding this comment.
Je, I used the wrong unit! It should be 1 min. Thanks!
dvush
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
New parameter time_to_keep_mempool_txs_secs replaces old hardcoded constant BLOCKS_TO_KEEP_TXS.
New metric so measure the mem used by mempool txs (so we can tune time_to_keep_mempool_txs_secs).
Updated config docs with time_to_keep_mempool_txs_secs and some more.
💡 Motivation and Context
It was unethical to kill so young txs.
✅ I have completed the following steps:
make lintmake test