Skip to content

Conversation

estensen
Copy link
Contributor

make lint doesn't use nightly Rust and is just noise

Run make lint
cargo fmt -- --check
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
...

https://github.com/flashbots/rbuilder/actions/runs/17913195731/job/50929259682?pr=717

Alternatively use nightly as referenced in

Follow the [Rust Style Guide](https://doc.rust-lang.org/nightly/style-guide/) recommendations.

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 11:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the nightly Rust formatting configuration to eliminate warnings during linting. The change removes a rustfmt configuration option that requires nightly Rust features, which was causing noise in the CI pipeline when using stable Rust.

  • Removes imports_granularity = "Crate" configuration that requires nightly Rust
  • Keeps reorder_imports = true which works with stable Rust
  • Eliminates warning messages during make lint execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ZanCorDX ZanCorDX merged commit 3783fb3 into flashbots:develop Oct 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants