Trace warn if order execution takes to long #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
approved these changes
Oct 14, 2025
| .max_order_execution_duration_warning | ||
| .is_some_and(|max_dur| sim_time > max_dur) | ||
| { | ||
| warn!(sim_ok,?sim_time,builder_name=self.builder_name,id = ?order.id(),txs = ?order.order.list_txs().iter().map(|(tx, _)| tx.hash()).collect::<Vec<_>>(), "Slow order execution"); |
There was a problem hiding this comment.
I found the following fields to be useful:
- tx from / to (can be only from the first tx or from all txs like you do here)
*bundle signer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR add a new config:
max_order_execution_duration_warning_us (optional u64): If set, while building a block if an order execution duration is greater than this, we will log a warning with some info about the order.
✅ I have completed the following steps:
make lintmake test