Skip to content

Proper non_mempool_coinbase_profit on DelayedRefunds #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Proper non_mempool_coinbase_profit on DelayedRefunds #801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e062999
proper non_mempool_coinbase_profit on DelayedRefunds
ZanCorDX Nov 4, 2025
b436bab
fixed test
ZanCorDX Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions crates/rbuilder/src/building/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,17 +1301,18 @@ pub fn create_sim_value(
// We don't filter for mempool txs.
order_ok.coinbase_profit
} else {
let non_mempool_coinbase_profit = order_ok
let mempool_coinbase_profit = order_ok
.tx_infos
.iter()
.filter(|tx_info| !mempool_detector.is_mempool(&tx_info.tx))
.filter(|tx_info| mempool_detector.is_mempool(&tx_info.tx))
.map(|tx_info| tx_info.coinbase_profit)
.sum::<I256>();
if non_mempool_coinbase_profit.is_zero() || non_mempool_coinbase_profit.is_positive() {
non_mempool_coinbase_profit.unsigned_abs()
if mempool_coinbase_profit.is_positive() {
order_ok
.coinbase_profit
.saturating_sub(mempool_coinbase_profit.unsigned_abs())
} else {
// This could be a bundle which was positive thanks to the inclusion of mempool txs.
U256::ZERO
order_ok.coinbase_profit
}
};

Expand Down Expand Up @@ -1345,7 +1346,7 @@ mod test {
let profit_1 = I256::unchecked_from(1000);
let profit_2 = I256::unchecked_from(10000);
let order_ok = OrderOk {
coinbase_profit: Default::default(),
coinbase_profit: (profit_1 + profit_2).unsigned_abs(),
space_used: Default::default(),
cumulative_space_used: Default::default(),
tx_infos: vec![
Expand Down
Loading