chore: remove separate optimistic signer #810
Merged
+40
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
approved these changes
Nov 12, 2025
| &submission_span, | ||
| &cancel, | ||
| submission_span.in_scope(|| { | ||
| // NOTE: we only notify normal submission here because they have the same contents but different pubkeys |
Contributor
There was a problem hiding this comment.
this comment is no longer relevant
ZanCorDX
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Remove separate optimistic signer and configuration to allow builder to use only a single signing key for submissions and remove double signing from the hot path.
✅ I have completed the following steps:
make lintmake test