Skip to content

Fixed finalize/roothash metrics #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fixed finalize/roothash metrics #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/rbuilder/src/building/builders/block_building_helper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ impl<
building_ctx: &BlockBuildingContext,
built_block_trace: &BuiltBlockTrace,
sim_gas_used: u64,
block_was_adjusted: bool,
) {
let txs = finalized_block.sealed_block.body().transactions.len();
let gas_used = finalized_block.sealed_block.gas_used;
Expand All @@ -317,6 +318,7 @@ impl<
sim_gas_used,
builder_name,
building_ctx.timestamp(),
block_was_adjusted,
);

trace!(
Expand Down Expand Up @@ -468,6 +470,7 @@ impl<
&self.building_ctx,
&self.built_block_trace,
sim_gas_used,
adjust_finalized_block,
);

self.finalize_adjustment_state = Some(finalize_adjustment_state);
Expand Down
39 changes: 24 additions & 15 deletions crates/rbuilder/src/telemetry/metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,18 @@ use tracing::error;
pub mod scope_meter;
mod tracing_metrics;
pub use tracing_metrics::*;

const FINALIZE_MODE_ADJUSTED: &str = "adjusted";
const FINALIZE_MODE_NORMAL: &str = "normal";

fn finalize_mode_label(adjusted: bool) -> &'static str {
if adjusted {
FINALIZE_MODE_ADJUSTED
} else {
FINALIZE_MODE_NORMAL
}
}

const SUBSIDY_ATTEMPT: &str = "attempt";
const SUBSIDY_LANDED: &str = "landed";

Expand Down Expand Up @@ -342,20 +354,14 @@ register_metrics! {
.unwrap();
pub static BLOCK_FINALIZE_TIME: HistogramVec = HistogramVec::new(
HistogramOpts::new("block_finalize_time", "Block Finalize Times (ms)")
.buckets(exponential_buckets_range(0.01, 3000.0, 200)),
&[]
)
.unwrap();
pub static BLOCK_FINALIZE_ADJUST_TIME: HistogramVec = HistogramVec::new(
HistogramOpts::new("block_finalize_adjust_time", "Block Finalize Adjust Times (ms)")
.buckets(exponential_buckets_range(0.01, 300.0, 200)),
&[]
.buckets(exponential_buckets_range(0.01, 2000.0, 200)),
&["mode"]
)
.unwrap();
pub static BLOCK_ROOT_HASH_TIME: HistogramVec = HistogramVec::new(
HistogramOpts::new("block_root_hash_time", "Block Root Hash Time (ms)")
.buckets(exponential_buckets_range(0.01, 2000.0, 200)),
&[]
&["mode"]
)
.unwrap();
pub static BLOCK_MULTI_BID_COPY_DURATION: HistogramVec = HistogramVec::new(
Expand Down Expand Up @@ -504,19 +510,22 @@ pub fn add_finalized_block_metrics(
sim_gas_used: u64,
builder_name: &str,
block_timestamp: OffsetDateTime,
block_was_adjusted: bool,
) {
if !is_now_close_to_slot_end(block_timestamp) {
return;
}

BLOCK_FINALIZE_TIME
.with_label_values(&[])
.observe(duration_ms(built_block_trace.finalize_time));
BLOCK_FINALIZE_ADJUST_TIME
.with_label_values(&[])
.observe(duration_ms(built_block_trace.finalize_adjust_time));
.with_label_values(&[finalize_mode_label(block_was_adjusted)])
.observe(duration_ms(if block_was_adjusted {
built_block_trace.finalize_adjust_time
} else {
built_block_trace.finalize_time
}));

BLOCK_ROOT_HASH_TIME
.with_label_values(&[])
.with_label_values(&[finalize_mode_label(block_was_adjusted)])
.observe(duration_ms(built_block_trace.root_hash_time));

BLOCK_BUILT_TXS
Expand Down
Loading