Rollup-boost uses ping/pong to test the connection is open #310
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
I checked on tungstine and there was not an internal support to do ping, not sure if others have support for it. |
Client side implementations do not have heartbeat implemented by default. In the server side it is enabled, if they get a Ping they reply with a Pong. |
| let (activity_tx, mut activity_rx) = mpsc::channel::<()>(10); | ||
|
|
||
| let timeout_task = tokio::spawn(async move { | ||
| let mut last_activity = Instant::now(); |
There was a problem hiding this comment.
Can we get more functions? I thinks this part could be spawn_activity_task, next could be spawn_ping_task, wdyt?
There was a problem hiding this comment.
Do you mean putting this logic in functions?
| send_ping_tx.send(()).await.unwrap(); | ||
| }, | ||
| _ => { | ||
| println!("Received message: {:?}", msg); |
There was a problem hiding this comment.
is this debugging message?
3 participants
This PR adds a ping/pong system over the Rollup-boost <-> Builder connection. The context of this PR is in #304.
The inbound websocket service will send ping messages to the builder if after some time interval x has not received any message from the builder. After sending the ping message, it will wait another n time duration to receive the pong message back.
The test still needs more work.