Add websocket support #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
SozinM
force-pushed
the
msozin/websocket-connection-to-op-node
branch
from
e0bfa68 to
5a090e5
Compare
avalonche
reviewed
Sep 4, 2025
| #[metric(describe = "Count of times flashblocks get_block_by_number is called")] | ||
| pub get_block_by_number: Counter, | ||
| #[metric(describe = "Count of times flashblocks block_by_number is called")] | ||
| pub block_by_number: Counter, |
There was a problem hiding this comment.
are there any docs that need updating for this?
avalonche
reviewed
Sep 4, 2025
|
|
all methods goes through the authrpc, so any method through the regular rpc will also break like miner_, eth_ |
avalonche
reviewed
Sep 9, 2025
crates/rollup-boost/src/server.rs
Outdated
|
|
||
| #[rpc(server, client)] | ||
| #[rpc(server, client, namespace = "engine")] | ||
| pub trait EngineApi { |
There was a problem hiding this comment.
maybe we can move all the method we don't have custom logic for (all the methods we just forward to l2) to a separate file to not clutter the server.rs file
avalonche
approved these changes
Sep 9, 2025
3 tasks
|
I won't fix kurtosis in this PR |
Removed previous http proxy implmenetaion Bump reth Disable flashblocks-rpc
SozinM
force-pushed
the
msozin/websocket-connection-to-op-node
branch
2 times, most recently
from
ceb634c to
f96f9f9
Compare
SozinM
commented
Sep 15, 2025
crates/rollup-boost/src/server.rs
Outdated
| } | ||
|
|
||
| async fn block_by_hash(&self, hash: B256, full: bool) -> RpcResult<Option<RpcBlock<Optimism>>> { | ||
| Ok(self.builder_client.block_by_hash(hash, full).await?) |
There was a problem hiding this comment.
remove before merge
SozinM
force-pushed
the
msozin/websocket-connection-to-op-node
branch
from
f96f9f9 to
0c1fb4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #393
Removed custom traits for APIs, now we are using reth traits directly. This ensures that we will catch all updates.
Fixed issue with vulnerable crate.
Temporary removed flashblocks-rpc from workspace, as it severely outdated.
Bumped reth to 1.7.0