[breaking-change] Improve ping/pong logic #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
|
does it have any backwards compatibility issues? |
Contributor
|
Have you looked at the https://github.com/Xuanwo/backon crate? It's more ergonomic and seems to be actively maintained |
avalonche
reviewed
Oct 14, 2025
Collaborator
|
would be good to add integration tests |
avalonche
reviewed
Oct 15, 2025
avalonche
reviewed
Oct 15, 2025
avalonche
reviewed
Oct 15, 2025
avalonche
approved these changes
Oct 15, 2025
akundaz
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
noot
reviewed
Oct 15, 2025
SozinM
force-pushed
the
msozin/fix-pongs
branch
from
7e6b839 to
a17d0e0
Compare
avalonche
changed the title
akundaz
approved these changes
Oct 17, 2025
Cover cornercase of rapid reconnections
SozinM
force-pushed
the
msozin/fix-pongs
branch
from
a17d0e0 to
ab8f32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes!
--flashblock-builder-ws-reconnect-ms was changed, now it consists of 2 params:
--flashblock-builder-ws-initial-reconnect-ms and --flashblock-builder-ws-max-reconnect-ms that are used in explonential backoff with multiplier 1.5 (timeout increased by 50% every unsuccessful reconnections and reset on successful connection)
--flashblock-builder-ws-ping-interval-ms - how often send pings
--flashblock-builder-ws-pong-timeout-ms - timeout for pong. If we haven't receive pong for ping that we send for timeout - close connection.