Skip to content

Conversation

@teddyknox
Copy link
Collaborator

@teddyknox teddyknox commented Nov 5, 2025

Modifies no behavior; not a breaking change

  • Split RollupBoostArgs into RollupBoostLibArgs (library) and RollupBoostServiceArgs (service).
  • RollupBoostServiceArgs flattens RollupBoostLibArgs via clap; existing CLI flags unchanged.
  • Updated server constructors and tracing/metrics init to use new types.
  • CLI users: no changes. Library users: migrate to RollupBoostLibArgs / RollupBoostServiceArgs.

Copilot AI review requested due to automatic review settings November 5, 2025 17:11
@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rollup-boost Ignored Ignored Nov 5, 2025 5:11pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the command-line argument structure by splitting RollupBoostArgs into two separate types: RollupBoostLibArgs for core library functionality and RollupBoostServiceArgs for service-level configuration.

  • Introduced RollupBoostLibArgs containing core arguments (builder, l2_client, execution_mode, etc.)
  • Created RollupBoostServiceArgs as the top-level parser that embeds RollupBoostLibArgs via a lib field
  • Updated all usages to access core arguments through the lib field where appropriate

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/rollup-boost/src/cli.rs Splits RollupBoostArgs into RollupBoostLibArgs and RollupBoostServiceArgs, with service-level args at top level and core lib args nested under lib field
crates/rollup-boost/src/server.rs Updates new_from_args methods to accept RollupBoostLibArgs instead of RollupBoostArgs
crates/rollup-boost/src/tracing.rs Updates init_tracing to use RollupBoostServiceArgs
crates/rollup-boost/src/metrics.rs Updates init_metrics to use RollupBoostServiceArgs
crates/rollup-boost/src/bin/main.rs Updates import and usage to RollupBoostServiceArgs
crates/rollup-boost/src/tests/common/services/rollup_boost.rs Updates test harness to use RollupBoostServiceArgs and removes unused clap::Parser import
crates/rollup-boost/src/tests/common/mod.rs Updates test code to access core arguments via .lib. nested field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avalonche avalonche merged commit cb1f98b into main Nov 5, 2025
14 of 15 checks passed
@avalonche avalonche deleted the teddyknox/args-refactor branch November 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants