refactor: move flashblock types to rollup-boost-types crate #450
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
noot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR extracts flashblock primitive types from the rollup-boost crate into a new rollup-boost-core crate to reduce dependency requirements for consumers. This allows downstream crates to import only the core types without building the entire rollup-boost binary.
Key changes:
- Created a new
rollup-boost-corecrate containingExecutionPayloadBaseV1,ExecutionPayloadFlashblockDeltaV1, andFlashblocksPayloadV1types - Updated all references throughout the codebase to import these types from the new core crate
- Added a temporary re-export in rollup-boost for backward compatibility
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rollup-boost-core/Cargo.toml | New crate definition with minimal alloy and serde dependencies |
| crates/rollup-boost-core/src/lib.rs | New module containing moved flashblock primitive types |
| crates/rollup-boost/src/flashblocks/primitives.rs | Removed file - types moved to core crate |
| crates/rollup-boost/src/lib.rs | Added re-export of core flashblocks types for backward compatibility |
| crates/rollup-boost/Cargo.toml | Added dependency on rollup-boost-core |
| crates/rollup-boost/src/flashblocks/*.rs | Updated imports to use rollup-boost-core |
| crates/flashblocks-rpc/*.rs | Updated imports to use rollup-boost-core directly |
| crates/flashblocks-rpc/Cargo.toml | Added rollup-boost-core dependency |
| Cargo.toml | Added rollup-boost-core to workspace members and dependencies |
| crates/rollup-boost/src/client/rpc.rs | Removed unused imports |
Comments suppressed due to low confidence (1)
crates/rollup-boost/Cargo.toml:4
- The Rust edition '2024' does not exist. The latest stable Rust edition as of November 2025 is '2021'. This should be changed to '2021'.
edition = "2024"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
How about calling it |
|
@akundaz i think i want to add other types in here (https://github.com/flashbots/rollup-boost/blob/main/crates/rollup-boost/src/payload.rs) that aren't flashblocks related, so would prefer non-flashblock naming |
julio4
left a comment
julio4
left a comment
There was a problem hiding this comment.
Ideally we might want to move it somewhere else later because flashblocks types could be used outside of rollup-boost context
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 26 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
noot
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 26 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 participants
consumers of flashblocks types should not be forced to import and build the entire rollup-boost binary to use some types.
iI ran into depedency hell when trying to modify simulator; I needed to update the reth dep, but simulator was also importing the entire rollup-boost library when it was only using the
FlashblocksPayloadV1type, which would have required me to also fork and update rollup-boost. with this change, that will no longer be necessary.op-rbuilder also imports the entire rollup-boost binary for only these types.