chore: drop ProxyInner and Proxy traits
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x416e746f6e
changed the title
ProxyInner traitProxyInner and Proxy traits
akundaz
reviewed
Oct 23, 2025
| proxy: &'static str, | ||
| remote_addr: Option<String>, | ||
| local_addr: Option<String>, | ||
| metrics: &Arc<Metrics>, |
Contributor
There was a problem hiding this comment.
No need to pass arcs by reference
Member
Author
There was a problem hiding this comment.
I thought cloning w/o real need was "bad"
akundaz
approved these changes
Oct 23, 2025
Contributor
akundaz
left a comment
akundaz
left a comment
There was a problem hiding this comment.
This is a step in the right direction but if you look carefully the ProxyHttpInner and ProxyWsInner traits are extremely similar
Member
Author
i.m.o. not all code that looks similar (or identical even) should be DRY-ed. merging the two will introduce unnecessary coupling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subj.