Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

Suavex rpc request library #51

Closed
wants to merge 2 commits into from
Closed

Suavex rpc request library #51

wants to merge 2 commits into from

Conversation

jinmel
Copy link
Contributor

@jinmel jinmel commented Feb 23, 2024

No description provided.

lthibault
lthibault approved these changes Feb 28, 2024
View reviewed changes
Copy link

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ferranbt
ferranbt suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ferranbt ferranbt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge some of this with #57

@zeroXbrock
Copy link
Member

Could we merge some of this with #57

merged this into #57 to replace the contents of the encoding methods in the Bundle lib

@zeroXbrock zeroXbrock mentioned this pull request Mar 13, 2024
Open
@jinmel
Copy link
Contributor Author

jinmel commented Mar 14, 2024

closing this issue by merge with #57

@jinmel jinmel closed this Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@metachris metachris Awaiting requested review from metachris metachris is a code owner

@zeroXbrock zeroXbrock Awaiting requested review from zeroXbrock zeroXbrock is a code owner

2 more reviewers

@ferranbt ferranbt ferranbt requested changes

@lthibault lthibault lthibault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jinmel @zeroXbrock @lthibault @ferranbt