Skip to content

Conversation

@Bernardoow
Copy link
Contributor

I read the code and saw the params of function add_marker is a dict. So, the unpack of variable, check and put on the dict again (I think) is a redunt and then I removed this.

This modification can break code because some ppl maybe use this function to add lat and lng out of build_markers function. But I suggest to remove this variable of param function and let just pass through the kwargs.

I checked on the examples if some call the function add_marker, but I didn't find the call.

@Riverfount
Copy link
Member

Hi @Bernadoow,

Please, fix the files conflicts! After it we can do the rebase!

@Riverfount Riverfount merged commit 7253932 into flask-extensions:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants