ci-automation: Don't skip nightly build when the previous one failed #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a duplicate function and verified that it's the only one via comm -12 <(sort ci-automation/ci_automation_common.sh) <(sort sdk_lib/sdk_container_common.sh) | grep function I'm not sure if this is due to a case where we only import one but can't import the other, hence I'm not deleting it now.
krnowak
reviewed
Sep 26, 2022
pothos
force-pushed
the
kai/nightly-after-failure
branch
from
81e859b to
8b8c4fb
Compare
krnowak
approved these changes
Sep 26, 2022
Member
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
There's an outdated comment, but otherwise looks good. Thanks for looking into this issue and fixing it.
Currently we skip the nightly build if there are no changes. This didn't work well because a new run doesn't fix any failure because the rerun became a no-op. Check if the main artifacts we expect from a step are found, as simple heuristic on whether a rerun is needed.
pothos
force-pushed
the
kai/nightly-after-failure
branch
from
8b8c4fb to
bca6e6e
Compare
pothos
added a commit
that referenced
this pull request
Sep 26, 2022
ci-automation: Don't skip nightly build when the previous one failed
pothos
added a commit
that referenced
this pull request
Sep 26, 2022
ci-automation: Don't skip nightly build when the previous one failed
pothos
added a commit
that referenced
this pull request
Sep 26, 2022
ci-automation: Don't skip nightly build when the previous one failed
pothos
added a commit
that referenced
this pull request
Sep 26, 2022
ci-automation: Don't skip nightly build when the previous one failed
pothos
added a commit
that referenced
this pull request
Sep 26, 2022
ci-automation: Don't skip nightly build when the previous one failed
tormath1
reviewed
Sep 26, 2022
| touch ./skip-build | ||
| echo "Creating ./skip-build flag file, indicating that the build must not to continue because no new tag got created as there are no changes since tag ${existing_tag}" >&2 | ||
| return 0 | ||
| if curl --head --fail --silent --show-error --location "https://${BUILDCACHE_SERVER}/images/amd64/${FLATCAR_VERSION}/flatcar_production_image.bin.bz2" |
Contributor
There was a problem hiding this comment.
Suggested change
| if curl --head --fail --silent --show-error --location "https://${BUILDCACHE_SERVER}/images/amd64/${FLATCAR_VERSION}/flatcar_production_image.bin.bz2" | |
| if curl --head --fail --silent --show-error --location "https://${BUILDCACHE_SERVER}/images/amd64/${FLATCAR_VERSION}/flatcar_production_image.bin.bz2" \ |
Otherwise it fails as currently:
17:20:48 jenkins/systemd-run-wrap.sh: ci-automation/packages-tag.sh: line 102: syntax error near unexpected token `&&'
17:20:48 jenkins/systemd-run-wrap.sh: ci-automation/packages-tag.sh: line 102: ` && curl --head --fail --silent --show-error --location "[https://${BUILDCACHE_SERVER}/images/arm64/${FLATCAR_VERSION}/flatcar_production_image.bin.bz2](https://${buildcache_server}/images/arm64/$%7BFLATCAR_VERSION%7D/flatcar_production_image.bin.bz2)"; then'
Contributor
There was a problem hiding this comment.
Just seen the fixing commit. Thanks!
Member
Author
There was a problem hiding this comment.
Lesson learnt: run shellcheck all the time^^
Contributor
There was a problem hiding this comment.
Might be we could add a simple github actions running shellcheck on PR?
Member
Author
There was a problem hiding this comment.
shellcheck -x --severity=warning is still a bit noisy until we fix the warnings, just =error isn't very helpful on the other hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we skip the nightly build if there are no changes. This
didn't work well because a new run doesn't fix any failure because the
rerun became a no-op.
Check if the main artifacts we expect from a step are found, as simple
heuristic on whether a rerun is needed.
How to use
backport
Testing done
None