Validate source early #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
reviewed
Sep 24, 2021
gasinvein
force-pushed
the
validate-source-early
branch
from
8f8f94e to
45ef49e
Compare
gasinvein
force-pushed
the
validate-source-early
branch
from
45ef49e to
0078d13
Compare
gasinvein
force-pushed
the
validate-source-early
branch
2 times, most recently
from
cad1882 to
4d7adae
Compare
wjt
requested changes
Sep 27, 2021
gasinvein
force-pushed
the
validate-source-early
branch
from
4d7adae to
7aec3fa
Compare
And raise exteptions for unsupported input instead of returning None.
gasinvein
force-pushed
the
validate-source-early
branch
from
7aec3fa to
70c4158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of schema errors in the manifest, f-e-d-c will usually throw an unhandled exception, which may not be easy for the user to figure out what's wrong.
Instead, validate source against a JSON schema as early as possible, and if the schema is invalid - print the error and skip such source.