jsonchecker: Use GitHub token for API queries, if set #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GITHUB_TOKEN env var is set and GitHub API host detected in JSON data url, add the token to Authorization header.
wjt
approved these changes
Oct 1, 2021
gasinvein
commented
Oct 1, 2021
| url = URL(url) | ||
|
|
||
| headers = {} | ||
| if url.host == "api.github.com": |
Collaborator
Author
There was a problem hiding this comment.
Here we rely on that yarl reliably parses URLs and can't be tricked into thinking that the host is different from what it really is. Otherwise, we can send our token to a malicious host, since the URL is provided by user.
@barthalion If you consider that this check is not enough (or you're paranoid like me), we can use different tokens for querying GitHub APIs here and opening/merging PRs in main.py.
Member
There was a problem hiding this comment.
It's fine by me the way it is now, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub REST API rate limit is rather low; the json checker can quickly drain it, what is currently happening with shared f-e-d-c instance on Flathub. We can authorize GitHub API queries to significantly increase this limit.
If
GITHUB_TOKENenv var is set, and GitHub API host detected in JSON data url, add the token toAuthorizationheader to authorize API request.