anityachecker: Handle no matching versions case #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasinvein
force-pushed
the
anityachecker-catch-errors
branch
from
b341086 to
1ef98a9
Compare
wjt
approved these changes
Oct 6, 2021
| try: | ||
| latest_version = versions[0] | ||
| except IndexError as err: | ||
| raise CheckerQueryError("Can't find matching version") from err |
Contributor
There was a problem hiding this comment.
Might be nice to give more details about why not:
Suggested change
| raise CheckerQueryError("Can't find matching version") from err | |
| raise CheckerQueryError(f"Can't find matching {'stable ' if stable_only else ''}version{ f' satisfying {constraints}' if constraints else ''}") from err |
but having written that, it's really hard to read, and I guess it will be obvious by looking at the manifest.
Collaborator
Author
There was a problem hiding this comment.
I guess it will be obvious by looking at the manifest.
Yeah. Also constraints will look messy when printed, since it's not just a dict but either OrderedDict or CommentedMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240