Skip to content

Update golangci-lint to v2.4.0#33251

Merged
getvictor merged 8 commits intomainfrom
victor/33250-golangci-lint-v2
Sep 22, 2025
Merged

Update golangci-lint to v2.4.0#33251
getvictor merged 8 commits intomainfrom
victor/33250-golangci-lint-v2

Conversation

@getvictor
Copy link
Copy Markdown
Member

@getvictor getvictor commented Sep 20, 2025 •
edited
Loading

Related issue: Resolves #33250

Waived most new failures. Planning to come back and fix some of them in subsequent PRs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.96%. Comparing base (84715f4) to head (06a4204).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/augeas/augeas_unix.go 0.00% 1 Missing ⚠️
orbit/pkg/table/firmwarepasswd/firmwarepasswd.go 0.00% 1 Missing ⚠️
server/mdm/nanodep/cmd/deptokens/main.go 0.00% 1 Missing ⚠️
server/mdm/scep/cmd/scepclient/cert.go 0.00% 1 Missing ⚠️
server/mdm/scep/cmd/scepclient/csr.go 0.00% 1 Missing ⚠️
server/mdm/scep/cmd/scepclient/key.go 0.00% 1 Missing ⚠️
server/service/apple_mdm.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #33251      +/-   ##
==========================================
+ Coverage   63.94%   63.96%   +0.02%     
==========================================
  Files        2048     2052       +4     
  Lines      202292   202758     +466     
  Branches     6664     6664              
==========================================
+ Hits       129351   129695     +344     
- Misses      62752    62855     +103     
- Partials    10189    10208      +19
Flag Coverage Δ
backend 65.07% <53.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor getvictor marked this pull request as ready for review September 22, 2025 12:11
@getvictor getvictor requested review from a team and lukeheath as code owners September 22, 2025 12:11
lucasmrod
lucasmrod reviewed Sep 22, 2025
View reviewed changes
Comment thread .golangci.yml
lucasmrod
lucasmrod reviewed Sep 22, 2025
View reviewed changes
Comment thread .golangci.yml
lucasmrod
lucasmrod reviewed Sep 22, 2025
View reviewed changes
Comment thread .golangci.yml Outdated
Comment on lines +12 to +13
- node_modules
- server/fleet/agent_options_generated.go # generated file
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth skipping any other big directories like frontend/?

Copy link
Copy Markdown
Member Author

@getvictor getvictor Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @lucasmrod, great suggestion

lucasmrod
lucasmrod reviewed Sep 22, 2025
View reviewed changes
Comment thread server/service/apple_mdm.go
lucasmrod
lucasmrod reviewed Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Left a few questions.

@lucasmrod lucasmrod self-assigned this Sep 22, 2025
lucasmrod
lucasmrod previously approved these changes Sep 22, 2025
View reviewed changes
lukeheath
lukeheath approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving workflow change

@getvictor getvictor merged commit e872f9a into main Sep 22, 2025
53 checks passed
@getvictor getvictor deleted the victor/33250-golangci-lint-v2 branch September 22, 2025 18:17
@sgress454 sgress454 mentioned this pull request Nov 21, 2025
Merged
sgress454 added a commit that referenced this pull request Nov 21, 2025
@sgress454
Update instructions for installing golangci-lint in dev environments (#…
c40f189 
…36125)

Updates the testing-and-local-development to reference the
`golangci-lint` version as of
#33251.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasmrod lucasmrod lucasmrod approved these changes

@lukeheath lukeheath lukeheath approved these changes

Assignees

@lucasmrod lucasmrod

@lukeheath lukeheath

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update golangci-lint to v2.4.0

3 participants

@getvictor @lucasmrod @lukeheath