Skip to content

Fix: View with content crashes in some routing scenarios #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Fix: View with content crashes in some routing scenarios #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ca4de2
Update __str__ for command
FeodorFitsner Feb 8, 2023
2535f7d
dart pub publish --force --dry-run
FeodorFitsner Feb 8, 2023
d840fb8
Remove drt run
FeodorFitsner Feb 8, 2023
19521fd
Fix: View with content crashes in some routing scenarios
FeodorFitsner Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ for:
if [[ "$APPVEYOR_REPO_TAG_NAME" != "" ]]; then
mkdir -p $HOME/.config/dart
echo $PUB_DEV_TOKEN | base64 --decode > $HOME/.config/dart/pub-credentials.json
#dart pub publish -f
dart pub publish --force
fi

# ======================================
Expand Down
4 changes: 3 additions & 1 deletion package/lib/src/models/control_view_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'package:collection/collection.dart';
import 'package:equatable/equatable.dart';
import 'package:redux/redux.dart';

Expand All @@ -16,7 +17,8 @@ class ControlViewModel extends Equatable {
return ControlViewModel(
control: store.state.controls[id]!,
children: store.state.controls[id]!.childIds
.map((childId) => store.state.controls[childId]!)
.map((childId) => store.state.controls[childId])
.whereNotNull()
.toList(),
dispatch: store.dispatch);
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/packages/flet-core/src/flet_core/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class Command:
commands: List[Any] = field(default_factory=list)

def __str__(self):
return "{} {}".format(self.values, self.attrs)
return "{} {} {}".format(self.name, self.values, self.attrs)


@dataclass
Expand Down