Added Container.blur and Container.shadow properties
#1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndonkoHenri
reviewed
Feb 23, 2023
ndonkoHenri
reviewed
Feb 23, 2023
ndonkoHenri
reviewed
Feb 25, 2023
Comment on lines
+57
to
+58
| sigma_x: float | ||
| sigma_y: float |
There was a problem hiding this comment.
Why only float?
Union[int, float] won't be better?
Comment on lines
+64
to
+65
| spread_radius: Optional[float] = field(default=None) | ||
| blur_radius: Optional[float] = field(default=None) |
There was a problem hiding this comment.
Same here. Union[int, float]
berecik
pushed a commit
to Marysia-Software-Limited/flet
that referenced
this pull request
Apr 3, 2023
* Container.blur initial check-in [skip ci] * Added `blur` property to `Container` Fix flet-dev#1062 * Grey color added * Added `Container.shadow` See https://blog.logrocket.com/enhance-mobile-apps-with-flutter-boxshadow/ for examples Close flet-dev#348 * Fix tests * Fix blur types
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
* Container.blur initial check-in [skip ci] * Added `blur` property to `Container` Fix flet-dev#1062 * Grey color added * Added `Container.shadow` See https://blog.logrocket.com/enhance-mobile-apps-with-flutter-boxshadow/ for examples Close flet-dev#348 * Fix tests * Fix blur types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blur docs: https://blog.logrocket.com/enhance-mobile-apps-with-flutter-boxshadow/
Shadow examples: https://blog.logrocket.com/enhance-mobile-apps-with-flutter-boxshadow/