-
Couldn't load subscription status.
- Fork 584
Supporting WebView control
#1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This Pull Request is related to flet |
|
Thanks for the PR! CI is failing though - could you please take a look: https://ci.appveyor.com/project/flet-dev/flet/build/job/klmymruxukgofl60 |
|
@FeodorFitsner oopps 🙂, any help please or suggestions from your side 👀? |
|
The problem is in https://pub.dev/packages/webview_universal package which prevents Linux client from building. What is that package for? |
|
@FeodorFitsner you are right, this is an unnecessary dependency. I did remove it. |
|
Thank you! Now I'd like to propose a name change for better consistency. Like in the title of this PR control is called And I'm still not sure whether we should separate them into So, I think we should call it just |
|
@FeodorFitsner thank you for your response! Eventually, this is was for me just as an experiment to see how flet works from the inside and making like a demo to my self for future contributs. I really can't thank you enough for your great work at flet. |
|
Good, let's rename it to |
|
ok @FeodorFitsner , How does it works then now? Close this Pull Request and start a new one? Or just rename this Pull Request and push new commit for the universal webview support with fixing the issues you marked? |
|
Just rename PR and push new commit(s). |
As Discussed in the PR, we will make the WebView Universal instead of Separating for each platform.
|
Hello @FeodorFitsner ,
Hope we go more further about this PR, accepting this a current mobile control widget, then do more researches maybe in another PR for making it more universal. |
* Supporting `WebView` control (#1865) * Supporting WebView for mobile. * update `MobileWebViewer` with document * remove Unnecessary flutter dependency * Update `MobileWebView` to become `WebView` As Discussed in the PR, we will make the WebView Universal instead of Separating for each platform. * Update python SDK to support the updates about the `WebView` --------- Co-authored-by: Feodor Fitsner <feodor@appveyor.com> * Added `--host` option to `flet run` command. * WebView control --------- Co-authored-by: Kot <86029286+SKbarbon@users.noreply.github.com>
* Supporting `WebView` control (flet-dev#1865) * Supporting WebView for mobile. * update `MobileWebViewer` with document * remove Unnecessary flutter dependency * Update `MobileWebView` to become `WebView` As Discussed in the PR, we will make the WebView Universal instead of Separating for each platform. * Update python SDK to support the updates about the `WebView` --------- Co-authored-by: Feodor Fitsner <feodor@appveyor.com> * Added `--host` option to `flet run` command. * WebView control --------- Co-authored-by: Kot <86029286+SKbarbon@users.noreply.github.com>
This pull request includes updates for both the Flet Flutter package and the Flet Python SDK. These updates introduce support for a WebView control on mobile platforms (iOS and Android) through the class named
MobileWebViewer.peek
Screen.Recording.2023-09-23.at.1.43.00.PM.mov
code example
desktop suggestion
I propose we distinguish between WebView components for desktop and mobile platforms. Typically, desktop WebView contains tools tailored for desktop-class functionality, which may not be accessible on mobile due to its limited capabilities. Merging these two types of WebView may constrain the capabilities of the desktop WebView widget. To address this, I recommend intentionally separating them by naming the desktop WebView as
DesktopWebViewerand keeping the mobile version asMobileWebViewer. This deliberate separation will help maintain the distinct features and capabilities of each platform.