Skip to content

Verify Slider.value limits #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Verify Slider.value limits #2121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion package/lib/src/controls/slider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,14 @@ class _SliderControlState extends State<SliderControl> {

double value = widget.control.attrDouble("value", 0)!;
if (_value != value) {
_value = value;
// verify limits
if (value < min) {
_value = min;
} else if (value > max) {
_value = max;
} else {
_value = value;
}
}

var slider = Slider(
Expand Down
8 changes: 7 additions & 1 deletion sdk/python/packages/flet-core/src/flet_core/slider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,13 @@ def _get_control_name(self):
# value
@property
def value(self) -> OptionalNumber:
return self._get_attr("value", data_type="float")
v = self._get_attr("value", data_type="float")
# verify limits
if v < self.min:
v = self.min
elif v > self.max:
v = self.max
return v

@value.setter
def value(self, value: OptionalNumber):
Expand Down